Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanup to forkchoice pkg #12078

Merged
merged 5 commits into from
Mar 6, 2023
Merged

Minor cleanup to forkchoice pkg #12078

merged 5 commits into from
Mar 6, 2023

Conversation

terencechain
Copy link
Member

  • Fix typos
  • Remove unused ProposerBoostRootArgs
  • Shuffle methods into more aligning interfaces Tips and IsOptimistic is more Getter than HeadRetriever

@terencechain terencechain added Ready For Review A pull request ready for code review OK to merge Cleanup Code health! labels Mar 5, 2023
@terencechain terencechain requested a review from a team as a code owner March 5, 2023 17:47
@terencechain terencechain self-assigned this Mar 5, 2023
potuz
potuz reviewed Mar 5, 2023
View reviewed changes
beacon-chain/forkchoice/interfaces.go
@@ -63,10 +60,11 @@ type Getter interface {
BestJustifiedCheckpoint() *forkchoicetypes.Checkpoint
NodeCount() int
HighestReceivedBlockSlot() primitives.Slot
HighestReceivedBlockRoot() [32]byte
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not used either?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed not used. I can also remove the implementation

@prylabs-bulldozer prylabs-bulldozer bot merged commit 78d49fd into develop Mar 6, 2023
@delete-merged-branch delete-merged-branch bot deleted the cleanup-fc-pkg branch March 6, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potuz potuz potuz approved these changes

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon prestonvanloon is a code owner automatically assigned from prysmaticlabs/core-team

@saolyn saolyn Awaiting requested review from saolyn saolyn is a code owner automatically assigned from prysmaticlabs/core-team

@james-prysm james-prysm Awaiting requested review from james-prysm james-prysm is a code owner automatically assigned from prysmaticlabs/core-team

Assignees

@terencechain terencechain

Labels
Cleanup Code health! Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terencechain @potuz